Skip to content

[Merged by Bors] - Rust 1.58 lints #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelsproul wants to merge 2 commits into from
Closed

[Merged by Bors] - Rust 1.58 lints #2906

michaelsproul wants to merge 2 commits into from

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Jan 13, 2022

Issue Addressed

Closes #2616

Proposed Changes

@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Jan 13, 2022
@michaelsproul
Copy link
Member Author

michaelsproul commented Jan 13, 2022 •
edited
Loading

This will fail CI until Rust 1.58 actually comes out

Alternatively we can split out the new lint into a different commit

paulhauner
paulhauner approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul
Copy link
Member Author

michaelsproul commented Jan 13, 2022

bors r+

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 13, 2022
bors bot pushed a commit that referenced this pull request Jan 13, 2022
@michaelsproul
Rust 1.58 lints (#2906)
e8887ff 
## Issue Addressed

Closes #2616

## Proposed Changes

* Fixes for new Rust 1.58.0 lints
* Enable the `fn_to_numeric_cast_any` (#2616)
@michaelsproul michaelsproul mentioned this pull request Jan 13, 2022
Closed
@bors
Copy link

bors bot commented Jan 14, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Rust 1.58 lints [Merged by Bors] - Rust 1.58 lints Jan 14, 2022
@bors bors bot closed this Jan 14, 2022
@michaelsproul michaelsproul deleted the rust-1.58-lints branch January 14, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelsproul @paulhauner